feat: add dark theme for LMS pages and MFEs #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hinakhadim
force-pushed
the
hina/redwood-dark
branch
from
359c471
to
481567b
Compare
regisb
reviewed
Jul 15, 2024
| @@ -0,0 +1,170 @@ | |||
| <%page args="section_data" expression_filter="h"/> | |||
There was a problem hiding this comment.
What part(s) of this file where modified, compared to upstream? As usual, we should hightlight them with a comment. I couldn't find such a comment, but maybe I didn't look straight ;)
There was a problem hiding this comment.
Regis, there is no comment. We wrapped a heading (h4) and .enrollment-wrapper div in course-info div for styling. I have removed this file as it doesn't seem good to override the file for adding a new div. Thanks for pointing it out.
tutorindigo/templates/indigo/lms/templates/courseware/course_about_sidebar_header.html
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Dark theme for the following:
Discover Page
The whole flow is:
To implement the Indigo theme, few HTML templates and sass stylings have been customized to give Open edX a new look. For MFEs styling, improvements have been made using the brand-openedx package and included the indigo brand-openedx
published package in the tutor-indigo plugin for being a part of MFEs. A config variable
ENABLE_DARK_THEMEhas been added to the dark theme for the indigo plugin.Behind the scenes, when this config variable is enabled, a class named
indigo-dark-themeis added to the body tag of HTML templates. If the config variable is enabled, the-theme=darkare being passed as parameter to the npm install the indigo-brand-openedx package. When the--theme=darkparameter is passed, it copies dark theme files in the indigo-brand-openedx package to the main package using post npm install.