Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modsecurity-regression-test-secremoterules.txt URL in example #3287

Conversation

hnakamur
Copy link
Contributor

what

  • Fix modsecurity-regression-test-secremoterules.txt URL in example

why

references

  • The URL is changed to the same one in 62ec4ed

Copy link

@marcstern marcstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we use a URL in this repo?

@hnakamur
Copy link
Contributor Author

Hi, I added the referenced files and change the code and configs to use them.

@airween
Copy link
Member

airween commented Oct 31, 2024

Hi @hnakamur,

thanks for this PR, that's a good catch.

Unfortunately some regression tests were failed, see this or this one.

I think you should split up this PR into two parts. First just send the files that you want to access remotely. After we merged those you can add the rest.

Also please note that there was a discussion on Slack about future of ModSecurity, where it was suggested that some functions should be eliminated, eg. SecRemoteRules.

@hnakamur hnakamur force-pushed the fix_modsecurity-regression-test-secremoterules.txt_url_in_example branch from 0b44620 to 0016815 Compare November 1, 2024 09:05
@hnakamur
Copy link
Contributor Author

hnakamur commented Nov 1, 2024

Thanks for your comment.
I sent another pull request Add regression rules for test by hnakamur · Pull Request #3291 · owasp-modsecurity/ModSecurity to add needed files.

I will rebase this pull request when #3291 is merged.

@airween
Copy link
Member

airween commented Nov 2, 2024

@hnakamur,

thanks for all!

@airween
Copy link
Member

airween commented Nov 5, 2024

@hnakamur I merged the other PR, you can pick up that now - thanks!

@hnakamur hnakamur force-pushed the fix_modsecurity-regression-test-secremoterules.txt_url_in_example branch from 0016815 to 42a4018 Compare November 6, 2024 05:34
@hnakamur
Copy link
Contributor Author

hnakamur commented Nov 6, 2024

@airween Hi, I rebased the branch for rhis pull request - thanks!

Copy link

sonarcloud bot commented Nov 6, 2024

@airween
Copy link
Member

airween commented Nov 6, 2024

@hnakamur - thanks, awesome!

@airween airween merged commit 4a72000 into owasp-modsecurity:v3/master Nov 6, 2024
49 checks passed
@hnakamur hnakamur deleted the fix_modsecurity-regression-test-secremoterules.txt_url_in_example branch November 6, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants