-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix modsecurity-regression-test-secremoterules.txt URL in example #3287
Fix modsecurity-regression-test-secremoterules.txt URL in example #3287
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we use a URL in this repo?
Hi, I added the referenced files and change the code and configs to use them. |
Hi @hnakamur, thanks for this PR, that's a good catch. Unfortunately some regression tests were failed, see this or this one. I think you should split up this PR into two parts. First just send the files that you want to access remotely. After we merged those you can add the rest. Also please note that there was a discussion on Slack about future of ModSecurity, where it was suggested that some functions should be eliminated, eg. |
0b44620
to
0016815
Compare
Thanks for your comment. I will rebase this pull request when #3291 is merged. |
thanks for all! |
@hnakamur I merged the other PR, you can pick up that now - thanks! |
0016815
to
42a4018
Compare
@airween Hi, I rebased the branch for rhis pull request - thanks! |
Quality Gate passedIssues Measures |
@hnakamur - thanks, awesome! |
what
why
references