Refactor config initializer and options parser #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the `ConfigInitializer` class and the `run_options_parser` method in the `options.cr` file. In the `ConfigInitializer` class, the exception handling for creating the config file and reading the config file has been simplified. The previous code had unnecessary print statements and did not handle exceptions properly. Now, the code simply rescues any exception without printing any error messages. In the `options.cr` file, the case statements for generating completion scripts have been modified. The previous code printed instructions on how to save the completion scripts, but those instructions have been removed. Additionally, the `banner` method in the `noir.cr` file has been removed as it was not being used. These changes improve the readability and maintainability of the code. Signed-off-by: HAHWUL <hahwul@gmail.com>
github-actions
bot
added
⚙️ options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the
ConfigInitializerclass and therun_options_parsermethod in theoptions.crfile.In the
ConfigInitializerclass, the exception handling for creating the config file and reading the config file has been simplified. The previous code had unnecessary print statements and did not handle exceptions properly. Now, the code simply rescues any exception without printing any error messages.In the
options.crfile, the case statements for generating completion scripts have been modified. The previous code printed instructions on how to save the completion scripts, but those instructions have been removed. Additionally, thebannermethod in thenoir.crfile has been removed as it was not being used.These changes improve the readability and maintainability of the code.
Signed-off-by: HAHWUL hahwul@gmail.com