Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile to buld image based on Fedora36 #15

Merged
merged 8 commits into from
Aug 30, 2022

Conversation

saw-jan
Copy link
Contributor

@saw-jan saw-jan commented Aug 24, 2022

This is required as we want to run desktop-client GUI tests on a container based on Fedora.

Desktop client built from a ubuntu based container cannot be run for the tests in Fedora base container. see https://drone.owncloud.com/owncloud/client/12931/6/12

Tasks:

@saw-jan saw-jan marked this pull request as draft August 24, 2022 11:38
@saw-jan
Copy link
Contributor Author

saw-jan commented Aug 25, 2022

The pipeline amd64-latest is failing because image based on ubuntu21.04 cannot be built.
Error:

- E: The repository 'http://archive.ubuntu.com/ubuntu hirsute Release' does not have a Release file.

@saw-jan saw-jan marked this pull request as ready for review August 25, 2022 06:40
@saw-jan
Copy link
Contributor Author

saw-jan commented Aug 25, 2022

Need some review
CC @individual-it

@saw-jan
Copy link
Contributor Author

saw-jan commented Aug 25, 2022

I have tests ctets on the container built using this image. Ctests can also pass with this image (see https://drone.owncloud.com/owncloud/client/12955/6/6).
So, should we remove ubuntu and use only fedora?

We can only add fedora in this PR and then remove ubuntu if we decide (but the main thing is that this PR won't get green ci due to failure to build ubuntu 21.04 image)

@saw-jan saw-jan requested a review from individual-it August 25, 2022 11:20
@individual-it
Copy link
Contributor

I would like to hear the opinions of @TheOneRing and @fmoc

@saw-jan
Copy link
Contributor Author

saw-jan commented Aug 29, 2022

we want to eventually move to Ubuntu LTS version as Fedora is short-lived distribution.
owncloud-ci/squish#36 (review)

@saw-jan saw-jan force-pushed the image-on-fedora branch 2 times, most recently from 4b57634 to 943497e Compare August 29, 2022 08:34
@saw-jan
Copy link
Contributor Author

saw-jan commented Aug 29, 2022

The pipeline amd64-latest is failing because image based on ubuntu21.04 cannot be built. Error:

- E: The repository 'http://archive.ubuntu.com/ubuntu hirsute Release' does not have a Release file.

If we want to update latest base to 22.04 then the ctests pipelines can work on it. see https://drone.owncloud.com/owncloud/client/12971

But before updating the base the current latest image (owncloudci/client:latest) MUST be moved to another tag (such as owncloudci/client:u21.04-amd64) so that if anything doesn't work then we can choose to run tests on this tag.

Possible tags with this PR:
fedora: fedora, fedora-amd64, fedora-36-amd64
latest: latest, ubuntu-amd64, ubuntu-22.04-amd64
source: source, source-amd64
2.9: 2.9, 2.9-amd64

CC @individual-it @fmoc

@@ -1,5 +1,5 @@
# since we require a non-LTS release (which ships Qt 5.15 by default), we base the image directly on the ubuntu base image
FROM ubuntu:21.04
FROM ubuntu:22.04
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it be safe to update base to 22.04 for building desktop-client and running ctests?
As I have commented here ctests were running fine

CC @fmoc @TheOneRing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it would be great to have the current latest image as a backup tag

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, 22.04 is supported.

Copy link
Contributor Author

@saw-jan saw-jan Aug 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it would be great to have the current latest image as a backup tag

@fmoc Can we have a backup of the current latest image before merging this?
moving owncloudci/client:latest to something like owncloudci/client:ubuntu-21.04 (just to be safe)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made a backup on my repo: https://hub.docker.com/r/sawjan/client/tags
If that works then this PR is ready to be reviewed and merged!

@individual-it individual-it merged commit 660c5b2 into owncloud-ci:master Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants