-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dockerfile to buld image based on Fedora36 #15
Conversation
32be6c6
to
91ec3c7
Compare
The pipeline - E: The repository 'http://archive.ubuntu.com/ubuntu hirsute Release' does not have a Release file. |
91ec3c7
to
f8f0d8f
Compare
Need some review |
I have tests ctets on the container built using this image. Ctests can also pass with this image (see https://drone.owncloud.com/owncloud/client/12955/6/6). We can only add fedora in this PR and then remove ubuntu if we decide (but the main thing is that this PR won't get green ci due to failure to build ubuntu 21.04 image) |
I would like to hear the opinions of @TheOneRing and @fmoc |
we want to eventually move to Ubuntu LTS version as Fedora is short-lived distribution. |
4b57634
to
943497e
Compare
943497e
to
7559bea
Compare
If we want to update But before updating the base the current latest image ( Possible tags with this PR: |
798ca02
to
c04c9cf
Compare
c04c9cf
to
abcad90
Compare
@@ -1,5 +1,5 @@ | |||
# since we require a non-LTS release (which ships Qt 5.15 by default), we base the image directly on the ubuntu base image | |||
FROM ubuntu:21.04 | |||
FROM ubuntu:22.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it be safe to update base to 22.04
for building desktop-client and running ctests?
As I have commented here ctests were running fine
CC @fmoc @TheOneRing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it would be great to have the current latest image as a backup tag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, 22.04 is supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it would be great to have the current latest image as a backup tag
@fmoc Can we have a backup of the current latest image before merging this?
moving owncloudci/client:latest
to something like owncloudci/client:ubuntu-21.04
(just to be safe)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made a backup on my repo: https://hub.docker.com/r/sawjan/client/tags
If that works then this PR is ready to be reviewed and merged!
This is required as we want to run desktop-client GUI tests on a container based on Fedora.
Desktop client built from a ubuntu based container cannot be run for the tests in Fedora base container. see https://drone.owncloud.com/owncloud/client/12931/6/12
Tasks: