Draft: Rename stop and unregisterFolder methods #9252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we can use it not only on Windows, but also on macOS. `WinVfsSettingsVersion` has been removed, and for VFS and non-VFS cases the `SettingsVersion` is used.
- FolderDefinition::load can never fail, so just return the newly loaded FolderDefinition instead of passing it in by reference. This also removes an if statement, reducing the complexity. - FolderMan::addFolderInternal can never return a nullptr, so replace the if check in FolderMan::addFolder by an assert.
In case of `stop` this makes it clear if it is a temporary state and the connection is resumed later (e.g. when the client exits), or if it is permanent (e.g. when the sync older is going to be removed).
erikjv
force-pushed
the
work/vfs-renames
branch
from
fe8e456
to
e8d148e
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
@erikjv ? |
|
@erikjv please decide on whether you want to continue with this |
erikjv
changed the title
|
This should go in together with https://github.com/owncloud/client-desktop-vfs-win/pull/7 . I'm postponing this until after getting the tests running on windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of
stopthis makes it clear if it is a temporary stateand the connection is resumed later (e.g. when the client exits),
or if it is permanent (e.g. when the sync older is going to be
removed).