Skip to content

Commit

Permalink
[mpd] outputs: drop invalid outputsvolume key
Browse files Browse the repository at this point in the history
This key confuses some clients, and it isn't emitted by MPD, nor
documented to exist:
https://github.com/MusicPlayerDaemon/MPD/blob/9ff8e02e543ede2b1964e5ea3f26f00bf2ff90ec/src/output/Print.cxx

It was added in bdb2c74, but without explanation why it was added to
outputs command.

Signed-off-by: Fabian Groffen <grobian@gentoo.org>
  • Loading branch information
grobian authored and ejurgensen committed Sep 16, 2024
1 parent 94ce56d commit 75222ca
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions src/mpd.c
Original file line number Diff line number Diff line change
Expand Up @@ -3214,8 +3214,7 @@ mpd_command_toggleoutput(struct mpd_command_output *out, struct mpd_command_inpu
* outputname: Computer
* plugin: alsa
* outputenabled: 1
* outputvolume: 50
* https://mpd.readthedocs.io/en/latest/protocol.html#audio-output-devices
* https://mpd.readthedocs.io/en/latest/protocol.html#command-outputs
*/
static void
speaker_enum_cb(struct player_speaker_info *spk, void *arg)
Expand All @@ -3240,13 +3239,11 @@ speaker_enum_cb(struct player_speaker_info *spk, void *arg)
"outputid: %u\n"
"outputname: %s\n"
"plugin: %s\n"
"outputenabled: %d\n"
"outputvolume: %d\n",
"outputenabled: %d\n",
param->nextid,
spk->name,
plugin,
spk->selected,
spk->absvol);
spk->selected);
param->nextid++;
}

Expand Down

0 comments on commit 75222ca

Please sign in to comment.