[mpd] add binarylimit command (still unused) #1791
Conversation
src/mpd.c
Outdated
| { | ||
| unsigned int size; | ||
|
|
||
| if (argc <= 1) |
There was a problem hiding this comment.
This just logs an error message, no error is returned to the client. Shouldn't it be implemented like in e.g. mpd_command_consume? I also notice that the other handlers don't check argc. Instead min_argc is set in the handler struct (you are setting it to -1, but I think it should be 2).
There was a problem hiding this comment.
right I copied probably not the best example function
|
As you write the limit isn't used, but are there any of the existing commands where it should be used? I looked through the list of supported commands, and I didn't notice any that looked like they would have binary responses. Is that also your view? |
|
correct albumart is the first to use BINARY responose because I cannot test it here, I will write a function that pushes out something in the chunks as necessary for reuse in the albumart code |
| argv[1]); | ||
| return ACK_ERROR_ARG; | ||
| } | ||
|
|
There was a problem hiding this comment.
I see that for values < 64 bytes mpd errors with "Value too small". See ClientCommands.cxx. Maybe do the same?
There was a problem hiding this comment.
sensical, else stuff gets very inefficient – or even worse – we end up in an endless loop (size=0)
Maintain the binary limit, and use the default MPD uses too. This comes in handy when we are going to send binary responses such as in PR owntone#1780 Signed-off-by: Fabian Groffen <grobian@gentoo.org>
Signed-off-by: Fabian Groffen <grobian@gentoo.org>
|
Merged, thanks! |
Maintain the binary limit, and use the default MPD uses too. This comes in handy when we are going to send binary responses such as in PR#1780