[websocket] avoid crash when websocket port can't be bound #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simply using an unavailable port for websocket will make owntone crash during startup because it tries to cleanup resources that are not initialised at all. Be a bit more careful during deinit so we exit a bit more gracefully on this error condition. Signed-off-by: Fabian Groffen <grobian@gentoo.org>
ejurgensen
added a commit
that referenced
this pull request
Aug 14, 2024
|
Thanks for this. I have added a slightly different fix for the issue now (commit 92495a7). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply using an unavailable port for websocket will make owntone crash during startup because it tries to cleanup resources that are not initialised at all.
Be a bit more careful during deinit so we exit a bit more gracefully on this error condition.