perf(semantic): avoid repeated hashing resolving bindings

[overlookmotel]

WIP. Just an experiment really at this stage.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[overlookmotel]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• perf(semantic): avoid repeated hashing resolving bindings #4238 👈
• fix(semantic): do not resolve references after FormalParameters in TS type #4241
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #4238 will not alter performance

_{Comparing 07-12-perf_semantic_avoid_repeated_hashing_resolving_bindings (480090c) with main (ab41c52)}

Summary

✅ 32 untouched benchmarks

[overlookmotel]

@Boshen This is my attempt at oxc-project/backlog#83. It stores hashes and so avoids rehashing on every insert, but the benchmark result is meh. Disappointing!

I've tried tweaking it in a bunch of ways, but nothing seems to make much difference.

Do you think worth tidying it up and merging? Or leave it for now and see if storing hash in Atom and using that everywhere has more of an effect?

[Boshen]

Let's close. This'll make future changes harder.