add numeric-separator transformer

[ShuiRuTian]

Add numeric separator transformer.

This is a low hang fruit, why don't we pick it?

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[codspeed-hq]

CodSpeed Performance Report

Merging #7280 will not alter performance

_{Comparing ShuiRuTian:numberic-separator-transformer (97969e9) with main (84038ee)}

Summary

✅ 30 untouched benchmarks

[camc314]

i think this already happens in oxc_codegen:

oxc/crates/oxc_codegen/src/gen.rs

Line 1151 in 44375a5

p.print_non_negative_float(value);

playground

[ShuiRuTian]

i think this already happens in oxc_codegen:

oxc/crates/oxc_codegen/src/gen.rs

Line 1151 in 44375a5

p.print_non_negative_float(value);

playground

Indeed, then we do not need that for numberic literial.

bigint transformer is still in need anyway, right?

[camc314]

i guess so? not really familiar

oxc/crates/oxc_codegen/src/gen.rs

Line 1171 in 44375a5

p.print_str(self.raw.as_str());

looks like it prints the raw val from the original source text

[Boshen]

i guess so? not really familiar

oxc/crates/oxc_codegen/src/gen.rs

Line 1171 in 44375a5

p.print_str(self.raw.as_str());

looks like it prints the raw val from the original source text

Good catch, it should be removed from codegen.

[camc314]

we could probably minify in codegen ?