Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(transformer/arrow-functions): use IndexMap for super getter/setters #7317

Conversation

overlookmotel
Copy link
Collaborator

@overlookmotel overlookmotel commented Nov 16, 2024

Generate getter/setter declarations in same order as Babel by using IndexMap instead of HashMap to store super getter/setter method details.

Copy link

graphite-app bot commented Nov 16, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codspeed-hq bot commented Nov 16, 2024

CodSpeed Performance Report

Merging #7317 will not alter performance

Comparing 11-16-refactor_transformer_arrow-functions_use_indexmap_for_super_getter_setters (5d85386) with main (7d75130)

Summary

✅ 30 untouched benchmarks

Copy link
Member

Dunqing commented Nov 17, 2024

Merge activity

@Dunqing Dunqing force-pushed the 11-16-perf_transformer_arrow-function_optimize_generate_super_binding_name_ branch from d8e397f to 4892875 Compare November 17, 2024 05:10
Dunqing pushed a commit that referenced this pull request Nov 17, 2024
…ter/setters (#7317)

Generate getter/setter declarations in same order as Babel by using `IndexMap` instead of `HashMap` to store `super` getter/setter method details.
@Dunqing Dunqing force-pushed the 11-16-refactor_transformer_arrow-functions_use_indexmap_for_super_getter_setters branch from 65bd6a8 to 6472077 Compare November 17, 2024 05:10
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 17, 2024
@overlookmotel overlookmotel force-pushed the 11-16-perf_transformer_arrow-function_optimize_generate_super_binding_name_ branch from 4892875 to 061207d Compare November 17, 2024 10:01
overlookmotel added a commit that referenced this pull request Nov 17, 2024
…ter/setters (#7317)

Generate getter/setter declarations in same order as Babel by using `IndexMap` instead of `HashMap` to store `super` getter/setter method details.
@overlookmotel overlookmotel force-pushed the 11-16-refactor_transformer_arrow-functions_use_indexmap_for_super_getter_setters branch from 6472077 to 3555cf9 Compare November 17, 2024 10:01
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Nov 17, 2024
…ter/setters (#7317)

Generate getter/setter declarations in same order as Babel by using `IndexMap` instead of `HashMap` to store `super` getter/setter method details.
@overlookmotel overlookmotel force-pushed the 11-16-perf_transformer_arrow-function_optimize_generate_super_binding_name_ branch from 061207d to 0a24703 Compare November 17, 2024 10:10
@overlookmotel overlookmotel force-pushed the 11-16-refactor_transformer_arrow-functions_use_indexmap_for_super_getter_setters branch from 3555cf9 to 5d85386 Compare November 17, 2024 10:10
Base automatically changed from 11-16-perf_transformer_arrow-function_optimize_generate_super_binding_name_ to main November 17, 2024 10:36
@graphite-app graphite-app bot merged commit 5d85386 into main Nov 17, 2024
29 checks passed
@graphite-app graphite-app bot deleted the 11-16-refactor_transformer_arrow-functions_use_indexmap_for_super_getter_setters branch November 17, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants