chart: support configuring worker controller type #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabloromeo
requested changes
Jul 25, 2024
| @@ -8,7 +8,7 @@ image: | |||
| imagePullPolicy: '{{ .Values.global.plexImage.imagePullPolicy }}' | |||
|
|
|||
| controller: | |||
| type: statefulset | |||
| type: '{{ .Values.worker.config.type | default "statefulset" }}' | |||
There was a problem hiding this comment.
Any chance you could add this new worker.config.type parameter and its possible values to the chart's README.md (https://github.com/pabloromeo/clusterplex/blob/master/charts/clusterplex/README.md)?
There was a problem hiding this comment.
Done, however I used the helm-docs tool which generated a lot more changes than I was expecting. I could put my change in manually if you want.
There was a problem hiding this comment.
Ah, yeah, in fact you did the right thing. My instructions were incorrect.
Let me take a look tomorrow to see if the contents still looks correct and we'll merge it in.
craigcabrey
force-pushed
the
craigcabrey/feat/worker-controller-type
branch
from
0cf3ba9
to
0456a89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimal backwards compatible change to support changing the controller type for workers. It is currently hardcoded as a statefulset, but I wanted to use a deployment instead.