Fix get_fork for Pagure #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When getting the fork from existing forks, check for equality of the usernames and not only substring check with 'in' operator. This prevents getting a fork of 'packit-stg' for user 'packit'. Fixes packit/packit-service#2178
mfocko
approved these changes
Sep 7, 2023
|
I guess we could add release notes to this 😄 |
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 42s |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 2m 15s |
softwarefactory-project-zuul
bot
merged commit 8ebc261
into
packit:main
24 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When getting the fork from existing forks, check for equality of the usernames and not only substring check with 'in' operator. This prevents getting a fork of 'packit-stg' for user 'packit'.
Fixes packit/packit-service#2178
RELEASE NOTES BEGIN
We have fixed a bug in
get_forkmethod for Pagure about checking the usernames for a match when going through existing forks.RELEASE NOTES END