Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to pyproject.toml and hatchling and get rid of setuptools_scm_git_archive #808

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Switch to pyproject.toml and hatchling and get rid of setuptools_scm_git_archive #808

merged 3 commits into from
Oct 2, 2023

Conversation

nforro
Copy link
Member

@nforro nforro commented Sep 26, 2023 •
edited
Loading

Fixes #798.
Fixes #805.

@softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@nforro nforro force-pushed the setuptools_scm branch 2 times, most recently from 6f5688c to 1b919bf Compare September 26, 2023 13:52
@softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/dab534d01d1341129a95dc511c8161f5

✔️ pre-commit SUCCESS in 1m 43s
✔️ ogr-tests-rpm SUCCESS in 10m 24s
✔️ ogr-tests-pip-deps SUCCESS in 10m 31s
✔️ ogr-reverse-dep-packit-tests SUCCESS in 15m 39s

@nforro nforro mentioned this pull request Sep 26, 2023
Merged
@nforro nforro marked this pull request as ready for review September 26, 2023 17:48
@nforro nforro changed the title Stop depending on setuptools_scm_git_archive Switch to pyproject.toml and hatchling and get rid of setuptools_scm_git_archive Sep 26, 2023
@nforro nforro mentioned this pull request Sep 26, 2023
Closed
1 task
@nforro
Copy link
Member Author

nforro commented Sep 26, 2023

Koji builds should be fixed by packit/sandcastle#198.

softwarefactory-project-zuul bot added a commit to packit/sandcastle that referenced this pull request Sep 27, 2023
@softwarefactory-project-zuul
Install packages needed for Python projects using hatch-vcs (#198)
430f7f5 
Install packages needed for Python projects using hatch-vcs

Merge before packit/ogr#808.

Reviewed-by: Laura Barcziová
@nforro
Copy link
Member Author

nforro commented Sep 27, 2023

/packit-stg rebuild-failed

@nforro
Copy link
Member Author

nforro commented Sep 27, 2023

/packit-stg upstream-koji-build

4 similar comments
@nforro
Copy link
Member Author

nforro commented Sep 27, 2023

/packit-stg upstream-koji-build

@nforro
Copy link
Member Author

nforro commented Sep 27, 2023

/packit-stg upstream-koji-build

@nforro
Copy link
Member Author

nforro commented Sep 27, 2023

/packit-stg upstream-koji-build

@nforro
Copy link
Member Author

nforro commented Sep 27, 2023

/packit-stg upstream-koji-build

@nforro
Switch to pyproject.toml and hatchling
d830fd7 
Signed-off-by: Nikola Forró <nforro@redhat.com>
@nforro
Use pyproject macros
b257e74 
Signed-off-by: Nikola Forró <nforro@redhat.com>
@nforro
Stop depending on setuptools_scm_git_archive
70fa3a6 
Signed-off-by: Nikola Forró <nforro@redhat.com>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/db173d5b17ca427383674cd7e52b3f7e

✔️ pre-commit SUCCESS in 1m 43s
✔️ ogr-tests-rpm SUCCESS in 11m 01s
✔️ ogr-tests-pip-deps SUCCESS in 10m 50s
✔️ ogr-reverse-dep-packit-tests SUCCESS in 16m 14s

@nforro nforro added the mergeit When set, zuul wil gate and merge the PR. label Oct 2, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/8ed0b3e866364750aaceadef6c72dfb0

✔️ pre-commit SUCCESS in 1m 44s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 69de9bd into packit:main Oct 2, 2023
20 of 24 checks passed
@nforro nforro deleted the setuptools_scm branch October 2, 2023 09:50
@nforro nforro mentioned this pull request Oct 2, 2023
Merged
softwarefactory-project-zuul bot added a commit to packit/packit that referenced this pull request Oct 2, 2023
@softwarefactory-project-zuul
Remove unneeded references to setuptools_scm_git_archive and update o…
117cf6d 
…gr test files (#2105)

Remove unneeded references to setuptools_scm_git_archive and update ogr test files

Related to packit/ogr#808.

Reviewed-by: Laura Barcziová
Reviewed-by: Maja Massarini
@nforro nforro mentioned this pull request Oct 6, 2023
Merged
softwarefactory-project-zuul bot added a commit to packit/sandcastle that referenced this pull request Oct 6, 2023
@softwarefactory-project-zuul
Install python-build for Python projects using it (#200)
a7f40ec 
Install python-build for Python projects using it

Related to packit/ogr#808.

Reviewed-by: Maja Massarini
Reviewed-by: Laura Barcziová
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpopelka jpopelka jpopelka approved these changes

Assignees
No one assigned
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setuptools_scm_git_archive is obsolete since setuptools_scm version 7 2023 python packaging
2 participants
@nforro @jpopelka