Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for removing users/groups from a project and allow to check for groups with permissions to modify a PR #815

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Add support for removing users/groups from a project and allow to check for groups with permissions to modify a PR #815

merged 3 commits into from
Oct 10, 2023

Conversation

nforro
Copy link
Member

@nforro nforro commented Oct 9, 2023 •
edited by lachmanfrantisek
Loading

Related to packit/packit#2078.

Merge before packit/packit#2112.

RELEASE NOTES BEGIN
Add support for removing users/groups from a project and allow to check for groups with permissions to modify a PR.
RELEASE NOTES END

@nforro
Copy link
Member Author

nforro commented Oct 9, 2023

/packit-stg rebuild-failed

@nforro
Copy link
Member Author

nforro commented Oct 9, 2023

/packit rebuild-failed

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/5af7466ade2d4b9290b014b67e198bb4

✔️ pre-commit SUCCESS in 2m 18s
✔️ ogr-tests-pip-deps SUCCESS in 11m 32s

@nforro
Copy link
Member Author

nforro commented Oct 9, 2023

/packit retest-failed

@nforro
Copy link
Member Author

nforro commented Oct 10, 2023

/packit upstream-koji-build

lbarcziova
lbarcziova approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ogr/abstract.py Outdated Show resolved Hide resolved
@lbarcziova
Copy link
Member

could you please also update COMPATIBILITY.md?

@nforro
Add support for removing users/groups from a project
8cbc9d9 
Signed-off-by: Nikola Forró <nforro@redhat.com>
@nforro
Allow to check for groups with permissions to modify a PR
6de1874 
Signed-off-by: Nikola Forró <nforro@redhat.com>
@nforro
Copy link
Member Author

nforro commented Oct 10, 2023

could you please also update COMPATIBILITY.md?

It looks like add_group is also missing from the document (not supported on GitHub and GitLab), I'll add it as well.

@nforro
Update COMPATIBILITY.md
4ded59c 
Signed-off-by: Nikola Forró <nforro@redhat.com>
lbarcziova
lbarcziova approved these changes Oct 10, 2023
View reviewed changes
COMPATIBILITY.md
Comment on lines +54 to 64
| | GitHub | GitLab | Pagure |
| --------------------------- | :----: | :----: | :---------------------: |
| `change_token` | ✘ | ✔ | ✔ |
| `get_release` | ✔ | ✔ | ✘ |
| `get_latest_release` | ✔ | ✔ | ✘ |
| `is_private` | ✔ | ✔ | ✘ (may not be accurate) |
| `remove_user` | ✘ | ✘ | ✔ |
| `add_group` | ✘ | ✘ | ✔ |
| `remove_group` | ✘ | ✘ | ✔ |
| `which_groups_can_merge_pr` | ✘ | ✘ | ✔ |

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@nforro
Copy link
Member Author

nforro commented Oct 10, 2023

/packit upstream-koji-build

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/577a952c3a3e4da7afcfcc2f5f6ca502

✔️ pre-commit SUCCESS in 2m 02s
✔️ ogr-tests-pip-deps SUCCESS in 11m 03s

@nforro nforro added the mergeit When set, zuul wil gate and merge the PR. label Oct 10, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/aff036ee61924bafb2800fa09169adfe

✔️ pre-commit SUCCESS in 1m 55s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 5ad36b6 into packit:main Oct 10, 2023
24 checks passed
@nforro nforro deleted the fork-force-push branch October 10, 2023 09:53
@nforro nforro mentioned this pull request Oct 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbarcziova lbarcziova lbarcziova approved these changes

Assignees
No one assigned
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nforro @lbarcziova