Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GithubRelease.url to not return API url #824

Merged

Conversation

lbarcziova
Copy link
Member

@lbarcziova lbarcziova commented Dec 4, 2023

Change the property so that it returns the html_url of the raw release and not the url which is the API url.

Merge before/after

RELEASE NOTES BEGIN
We have fixed a bug that GithubRelease.url returned an API URL.
RELEASE NOTES END

Copy link
Contributor

Copy link
Member

@mfocko mfocko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bug fix, you could probably add the release notes.

Change the property so that it returns the html_url of
the raw release and not the url which is the API url.
Copy link
Contributor

@lbarcziova lbarcziova added the mergeit When set, zuul wil gate and merge the PR. label Dec 5, 2023
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/6c2725fa4d644614a883b8c1043a4ad9

✔️ pre-commit SUCCESS in 2m 16s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit ed4342e into packit:main Dec 5, 2023
25 checks passed
@lbarcziova lbarcziova deleted the release-github-url branch December 5, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants