Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement get_pr_diff for Pagure #826

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

lbarcziova
Copy link
Member

@lbarcziova lbarcziova commented Dec 11, 2023

Needed for packit/packit-service#2271

TODO:

  • test

RELEASE NOTES BEGIN
There is a new get_pr_files_diff method supported for Pagure.
RELEASE NOTES END

Copy link
Contributor

ogr/abstract.py Outdated Show resolved Hide resolved
@lbarcziova lbarcziova marked this pull request as ready for review December 12, 2023 11:22
Copy link
Contributor

@lbarcziova lbarcziova added the mergeit When set, zuul wil gate and merge the PR. label Dec 12, 2023
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/14f24ef7138049e38694e676c4bd358e

✔️ pre-commit SUCCESS in 2m 03s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 7a7dd21 into packit:main Dec 12, 2023
21 checks passed
@lbarcziova lbarcziova deleted the get-pr-diff branch December 12, 2023 12:28
softwarefactory-project-zuul bot added a commit to packit/packit-service that referenced this pull request Dec 15, 2023
Adjust check of dist-git PRs for Koji builds

If the dist-git push comes from a PR, check that
the specfile was changed in that PR.
Related to #2271
Needs packit/ogr#826
TODO:

 Write new tests or update the old ones to cover new functionality.


RELEASE NOTES BEGIN
We have fixed a bug of not running Koji builds for Packit PRs with multiple commits if the last commit of the PR did not contain the specfile change.
RELEASE NOTES END

Reviewed-by: Nikola Forró
Reviewed-by: Laura Barcziová
Reviewed-by: František Lachman <flachman@redhat.com>
Reviewed-by: Maja Massarini
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants