Add getting groups and users with given access rights for Pagure #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 44s |
lbarcziova
added a commit
to lbarcziova/packit-service
that referenced
this pull request
Jan 24, 2024
Introduce aliases `all_admins` and `all_committers` and also support groups in allowed_pr_authors and allowed_committers config options Fixes packit/packit#2088 Requires packit/ogr#834
2 tasks
nforro
reviewed
Jan 25, 2024
nforro
reviewed
Jan 25, 2024
nforro
reviewed
Jan 25, 2024
nforro
approved these changes
Jan 25, 2024
Also refactor the other methods and fix the logic regarding groups. E.g. can_merge_pr will now return True for users who are members of group that can merge PR.
lbarcziova
force-pushed
the
pagure-group-access
branch
from
8718fe3
to
c8bc591
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 24s |
nforro
approved these changes
Jan 25, 2024
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 2m 17s |
softwarefactory-project-zuul
bot
merged commit 1767349
into
packit:main
19 of 21 checks passed
lbarcziova
added a commit
to lbarcziova/packit-service
that referenced
this pull request
Jan 25, 2024
Introduce aliases `all_admins` and `all_committers` and also support groups in allowed_pr_authors and allowed_committers config options Fixes packit/packit#2088 Requires packit/ogr#834
lbarcziova
added a commit
to lbarcziova/packit-service
that referenced
this pull request
Jan 26, 2024
Introduce aliases `all_admins` and `all_committers` and also support groups in allowed_pr_authors and allowed_committers config options Fixes packit/packit#2088 Requires packit/ogr#834
lbarcziova
added a commit
to lbarcziova/packit-service
that referenced
this pull request
Jan 26, 2024
Introduce aliases `all_admins` and `all_committers` and also support groups in allowed_pr_authors and allowed_committers config options Fixes packit/packit#2088 Requires packit/ogr#834
softwarefactory-project-zuul bot
added a commit
to packit/packit-service
that referenced
this pull request
Jan 29, 2024
Support aliases and groups in allowed_* config options for Koji Introduce aliases all_admins and all_committers and also support groups in allowed_pr_authors and allowed_committers config options Fixes packit/packit#2088 Requires packit/ogr#834 TODO: Write new tests or update the old ones to cover new functionality (needs packit/ogr#834) Update or write new documentation in packit/packit.dev. (packit/packit.dev#814) RELEASE NOTES BEGIN allowed_pr_authors and allowed_committers now allow specifying groups and also aliases all_admins and all_committers (corresponding to the access to the repository). RELEASE NOTES END Reviewed-by: Maja Massarini Reviewed-by: Laura Barcziová Reviewed-by: Nikola Forró
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for packit/packit#2088
RELEASE NOTES BEGIN
For Pagure there are 2 new methods available: one for getting users with specified access rights and one for getting members of a group.
RELEASE NOTES END