Skip to content

Commit

Permalink
chore(ci): breaking changes with for artifacts
Browse files Browse the repository at this point in the history
The `v4` of download/upload artifacts have some breaking changes. In particular, all artifacts must have different names now (i.e., it is no longer possible to append to the artifact).

Omitting the artifact name for the download will match all artifacts from the pipeline.

Signed-off-by: JP-Ellis <josh@jpellis.me>
  • Loading branch information
JP-Ellis committed Dec 17, 2023
1 parent 98a22b0 commit e904306
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,10 @@ jobs:
- name: Upload sdist
uses: actions/upload-artifact@c7d193f32edcb7bfad88892161225aeda64e9392 # v4
with:
name: wheels
name: wheels-sdist
path: ./dist/*.tar.*
if-no-files-found: error
compression-level: 0

build-x86_64:
name: Build wheels on ${{ matrix.os }} (x86, 64-bit)
Expand Down Expand Up @@ -81,9 +82,10 @@ jobs:
- name: Upload wheels
uses: actions/upload-artifact@c7d193f32edcb7bfad88892161225aeda64e9392 # v4
with:
name: wheels
name: wheels-${{ matrix.os }}-${{ matrix.archs }}
path: ./wheelhouse/*.whl
if-no-files-found: error
compression-level: 0

build-arm64:
name: Build wheels on ${{ matrix.os }} (arm64)
Expand Down Expand Up @@ -122,9 +124,10 @@ jobs:
- name: Upload wheels
uses: actions/upload-artifact@c7d193f32edcb7bfad88892161225aeda64e9392 # v4
with:
name: wheels
name: wheels-${{ matrix.os }}-${{ matrix.archs }}
path: ./wheelhouse/*.whl
if-no-files-found: error
compression-level: 0

check:
name: Check wheels
Expand All @@ -144,7 +147,6 @@ jobs:

- uses: actions/download-artifact@7a1cd3216ca9260cd8022db641d960b1db4d1be4 # v4
with:
name: wheels
path: wheelhouse

- run: |
Expand All @@ -166,7 +168,6 @@ jobs:
steps:
- uses: actions/download-artifact@7a1cd3216ca9260cd8022db641d960b1db4d1be4 # v4
with:
name: wheels
path: wheels

- name: Push build artifacts to PyPI
Expand Down

0 comments on commit e904306

Please sign in to comment.