Reduce CI Runs on Draft PRs #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As draft PRs are explicitly in a state which is not ready to be merged, there is no need to run the full suite of CI workflows every time there is an update. In particular, this commit disables: - Cirrus workflows, as Cirrus has a minute quota - Wheel builds - Long-running tests The test matrix is _still_ being run. Signed-off-by: JP-Ellis <josh@jpellis.me>
The previous configuration for concurrency group used `head_ref` incorrectly resulting in separate runs on master being cancelled. This solution was taken from: https://stackoverflow.com/a/75403978/1573761 Signed-off-by: JP-Ellis <josh@jpellis.me>
mefellows
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Limit a number CI workflows to run only on finalised PRs, specifically excluding draft PRs.
🚨 Breaking Changes🔥 Motivation
Draft PRs are a great way of sharing work that is in progress, but not yet ready to be reviewed and merged. Running a large number of CI workflows every time the draft PR is updated creates unnecessary noise.
Furthermore, Cirrus CI has monthly limits, and the draft PRs really have no reason to use up these resources.
🔨 Test Plan
See #413
🔗 Related issues/PRs