Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4 HTTP Consumer Compatibility Suite #563

Merged
merged 3 commits into from
Feb 27, 2024
Merged

V4 HTTP Consumer Compatibility Suite #563

merged 3 commits into from
Feb 27, 2024

Conversation

JP-Ellis
Copy link
Contributor

🔥 Motivation

Implements the V4/http_consumer.feature compatibility suite.

🔨 Test Plan

Passing the compatibility suite in regular CI workflow

🔗 Related issues/PRs

This functionality is shared between the V3 and V4 HTTP consumer tests.

Signed-off-by: JP-Ellis <josh@jpellis.me>
This introduces three new methods to the Interaction class:

- `set_key`
- `set_pending`
- `set_comment`

These are all used by V4 pacts.

Signed-off-by: JP-Ellis <josh@jpellis.me>
Signed-off-by: JP-Ellis <josh@jpellis.me>
@JP-Ellis JP-Ellis added difficulty:easy A simple task appropriate for newcomers to the codebase area:tests Relating to the testing area:v3 Relating to the pact.v3 module type:chore Part of regular code upkeep labels Feb 27, 2024
@JP-Ellis JP-Ellis self-assigned this Feb 27, 2024
@JP-Ellis JP-Ellis merged commit 9f737f0 into master Feb 27, 2024
31 of 42 checks passed
@JP-Ellis JP-Ellis deleted the chore/v4-consumer branch February 27, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:tests Relating to the testing area:v3 Relating to the pact.v3 module difficulty:easy A simple task appropriate for newcomers to the codebase type:chore Part of regular code upkeep
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v4/http_consumer.feature
1 participant