chore: revert table name to latest_verification_id_for_pact_version_a…

…nd_provider_version

Needed to specify custom foreign key name to avoid fk constraint name length violation in mysql

db/migrations/20180311_optimise_head_matrix.rb

@@ -18,7 +18,7 @@
     # Add provider_version_order to original definition
     # The most recent verification for each pact_version
     # provider_version column is DEPRECATED, use provider_version_number
-    # Think this can be replaced by latest_verif_id_for_pact_version_and_provider_version?
+    # Think this can be replaced by latest_verification_id_for_pact_version_and_provider_version?
     v = :verifications
     create_or_replace_view(:latest_verifications,
       from(v)

db/migrations/20180723_create_latest_verification_ids.rb

@@ -5,17 +5,18 @@
     # latest revision speeds queries up.
     # There is no way to delete an individual verification result yet, but when there
     # is, we'll need to re-calculate the latest.
-    create_table(:latest_verif_id_for_pact_version_and_provider_version, charset: 'utf8') do
-      foreign_key :consumer_id, :pacticipants, null: false, on_delete: :cascade # not required, but useful to avoid extra joins
-      foreign_key :pact_version_id, :pact_versions, null: false, on_delete: :cascade
-      foreign_key :provider_id, :pacticipants, null: false, on_delete: :cascade # not required, but useful to avoid extra joins
-      foreign_key :provider_version_id, :versions, null: false, on_delete: :cascade
-      foreign_key :verification_id, :verifications, null: false, on_delete: :cascade, unique: true
+    create_table(:latest_verification_id_for_pact_version_and_provider_version, charset: 'utf8') do
+      foreign_key :consumer_id, :pacticipants,      null: false, on_delete: :cascade, foreign_key_constraint_name: 'latest_v_id_for_pv_and_pv_consumer_id_fk' # not required, but useful to avoid extra joins
+      foreign_key :pact_version_id, :pact_versions, null: false, on_delete: :cascade, foreign_key_constraint_name: 'latest_v_id_for_pv_and_pv_pact_version_id_fk'
+      foreign_key :provider_id, :pacticipants,      null: false, on_delete: :cascade, foreign_key_constraint_name: 'latest_v_id_for_pv_and_pv_provider_id_fk'  # not required, but useful to avoid extra joins
+      foreign_key :provider_version_id, :versions,  null: false, on_delete: :cascade, foreign_key_constraint_name: 'latest_v_id_for_pv_and_pv_provider_version_id_fk'
+      foreign_key :verification_id, :verifications, null: false, on_delete: :cascade, foreign_key_constraint_name: 'latest_v_id_for_pv_and_pv_verification_id_fk'
+      index [:verification_id], unique: true, name: "latest_v_id_for_pv_and_pv_v_id_unq"
       index [:pact_version_id, :provider_version_id], unique: true, name: "unq_latest_verifid_pvid_provid"
     end
   end
 
   down do
-    drop_table(:latest_verif_id_for_pact_version_and_provider_version)
+    drop_table(:latest_verification_id_for_pact_version_and_provider_version)
   end
 end

db/migrations/20180724_migrate_latest_verification_ids.rb

@@ -9,10 +9,10 @@
         .select_append{ max(verifications[id]).as(verification_id) }
 
     # The danger with this migration is that a verification created by an old node will be lost
-    from(:latest_verif_id_for_pact_version_and_provider_version).insert(rows)
+    from(:latest_verification_id_for_pact_version_and_provider_version).insert(rows)
   end
 
   down do
-    from(:latest_verif_id_for_pact_version_and_provider_version).delete
+    from(:latest_verification_id_for_pact_version_and_provider_version).delete
   end
 end

db/migrations/20180726_recreate_views.rb

@@ -8,7 +8,7 @@
       from latest_pact_publication_ids_by_consumer_versions lpp
       inner join pact_publications pp
         on pp.id = lpp.pact_publication_id
-      left outer join latest_verif_id_for_pact_version_and_provider_version lv
+      left outer join latest_verification_id_for_pact_version_and_provider_version lv
           on lv.pact_version_id = pp.pact_version_id"
     )
 

db/migrations/20180727_recreate_latest_verification_ids_for_consumer_version_tags.rb

@@ -6,7 +6,7 @@
       v.consumer_id,
       t.name as consumer_version_tag_name,
       max(v.verification_id) as latest_verification_id
-    from latest_verif_id_for_pact_version_and_provider_version v
+    from latest_verification_id_for_pact_version_and_provider_version v
     join latest_pact_publication_ids_by_consumer_versions lpp
       on v.pact_version_id = lpp.pact_version_id
     join tags t

lib/pact_broker/api/resources/verification.rb

@@ -14,7 +14,7 @@ def content_types_provided
           [["application/hal+json", :to_json], ["application/json", :to_json]]
         end
 
-        # Remember to update latest_verif_id_for_pact_version_and_provider_version
+        # Remember to update latest_verification_id_for_pact_version_and_provider_version
         # if/when DELETE is implemented
         def allowed_methods
           ["GET", "OPTIONS"]

lib/pact_broker/verifications/repository.rb

@@ -43,7 +43,7 @@ def update_latest_verification_id verification
           consumer_id: verification.consumer_id
         }
 
-        table = PactBroker::Domain::Verification.db[:latest_verif_id_for_pact_version_and_provider_version]
+        table = PactBroker::Domain::Verification.db[:latest_verification_id_for_pact_version_and_provider_version]
         PactBroker::Repositories::Helpers.upsert(table, key, other)
       end