Skip to content

Commit

Permalink
feat(pacts for verification): include pending status for responses by…
Browse files Browse the repository at this point in the history
… default when includePendingStatus is not specified
  • Loading branch information
bethesque committed Sep 3, 2021
1 parent ac2bfe9 commit 748d3b8
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class PactsForVerificationQueryDecorator < BaseDecorator
}
end

property :include_pending_status, default: false,
property :include_pending_status, default: true,
setter: ->(fragment:, represented:, **) {
represented.include_pending_status = (fragment == "true" || fragment == true)
}
Expand Down

2 comments on commit 748d3b8

@bethesque
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uglyog @mefellows FYI - but I don't imagine it will make any difference, because I expect all the client libraries are probably sending an explicit false when it's not enabled. Will raise some issues to get the defaults changed in all the client libraries.

@mefellows
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks.

Please sign in to comment.