Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIN-5062 - Added outbound models #1

Merged
merged 12 commits into from
Jul 18, 2024
Merged

Conversation

Carminepo2
Copy link
Contributor

@Carminepo2 Carminepo2 commented Jul 11, 2024

Closes PIN-5062

First PR that adds the outbound event models.

@Carminepo2 Carminepo2 marked this pull request as ready for review July 16, 2024 08:17
- run: pnpm build
- run: npm publish
env:
NODE_AUTH_TOKEN: ${{ secrets.BOT_TOKEN }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed this guide.
BOT_TOKEN should be added to the repo secrets @galales

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀
I would leave to @micdes-pagopa the final word

Copy link
Contributor

@galales galales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 looks very good.
Added some cleanup comments.

Just one minor change in the specs: may I ask to add attributes fields in tenant?
I already updated the task on Jira.
Sorry for the rework 🙏

proto/v1/agreement/agreement.proto Outdated Show resolved Hide resolved
- run: pnpm build
- run: npm publish
env:
NODE_AUTH_TOKEN: ${{ secrets.BOT_TOKEN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀
I would leave to @micdes-pagopa the final word

proto/v1/agreement/state.proto Outdated Show resolved Hide resolved
proto/v1/eservice/events.proto Outdated Show resolved Hide resolved
proto/v1/tenant/events.proto Outdated Show resolved Hide resolved
proto/v2/agreement/agreement.proto Outdated Show resolved Hide resolved
proto/v2/eservice/events.proto Outdated Show resolved Hide resolved
@Carminepo2 Carminepo2 requested a review from galales July 17, 2024 08:55
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Carminepo2 and others added 2 commits July 17, 2024 15:58
Co-authored-by: Michele De Simone <106953981+micdes-pagopa@users.noreply.github.com>
Co-authored-by: Michele De Simone <106953981+micdes-pagopa@users.noreply.github.com>
@Carminepo2 Carminepo2 requested a review from AsterITA July 17, 2024 14:38
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SelfcareMappingCreatedV1 and SelfcareMappingDeletedV1 are not needed too?

Copy link

@beetlecrunch beetlecrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Carminepo2 Carminepo2 merged commit cfc5006 into main Jul 18, 2024
5 checks passed
@Carminepo2 Carminepo2 deleted the pin-5062-exported-events-models branch July 18, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants