Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [IOPLT-764] Upgrade to react-native 0.75 #6348

Open
wants to merge 76 commits into
base: master
Choose a base branch
from
Open

chore: [IOPLT-764] Upgrade to react-native 0.75 #6348

wants to merge 76 commits into from
+31,021 −18,709

Conversation

CrisTofani
Copy link
Contributor

@CrisTofani CrisTofani commented Oct 30, 2024 •
edited
Loading

Note

This PR depends on pagopa/io-cie-sdk#53 pagopa/io-react-native-jwt#34 pagopa/io-react-native-crypto#32

Short description

This PR bumps react-native to 0.75 and updates all necessary dependencies.

List of changes proposed in this pull request

  • Upgrade react-native to v 0.75.4
  • Updates yarn to version 3
  • Updates CI workflows
  • Removed Danger script
  • Adds PR linter and Link to Jira issue action to replace Danger

How to test

Anything should work as expected.

@CrisTofani CrisTofani mentioned this pull request Dec 3, 2024
Open
shadowsheep1
shadowsheep1 requested changes Dec 4, 2024
View reviewed changes
Copy link
Member

@shadowsheep1 shadowsheep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During my tests I was not able to use any debugging tools (e.g. Reactotron). Maybe we need to configure it? 🤔

Trying to open a Zendesk ticket in authenticated mode, I get always an error. @Ladirico can you give it a try too?

Anyway, all other tests were successful (CIE, and SPID login, first onboarding, onboarding, email change, account deletion, barcodes, etc.)

@CrisTofani
Copy link
Contributor Author

@shadowsheep1 good catch we had to update the version of reactotron

shadowsheep1
shadowsheep1 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@shadowsheep1 shadowsheep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The Zendesk part it doesn't seem to be related to this PR.

LazyAfternoons
LazyAfternoons requested changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@LazyAfternoons LazyAfternoons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we replaced Danger, do we still need the related scripts and the dependency declared in package.json?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LazyAfternoons LazyAfternoons LazyAfternoons requested changes

@LeleDallas LeleDallas LeleDallas approved these changes

@shadowsheep1 shadowsheep1 shadowsheep1 approved these changes

@dmnplb dmnplb Awaiting requested review from dmnplb dmnplb is a code owner

@ChrisMattew ChrisMattew Awaiting requested review from ChrisMattew ChrisMattew is a code owner

@gispada gispada Awaiting requested review from gispada gispada is a code owner

@freddi301 freddi301 Awaiting requested review from freddi301 freddi301 is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CrisTofani @pagopa-github-bot @LazyAfternoons @shadowsheep1 @LeleDallas @dmnplb