fix some sonarcloud issues

pagopa · Dec 6, 2024 · 8aaa337 · 8aaa337
1 parent f18c5c7
commit 8aaa337
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 9 deletions.
diff --git a/src/main/java/it/gov/pagopa/rtp/activator/service/rtp/SepaRequestToPayMapper.java b/src/main/java/it/gov/pagopa/rtp/activator/service/rtp/SepaRequestToPayMapper.java
@@ -15,6 +15,7 @@
 import it.gov.pagopa.rtp.activator.model.generated.epc.CreditTransferTransaction57EPC25922V30DS02Dto;
 import it.gov.pagopa.rtp.activator.model.generated.epc.CreditorPaymentActivationRequestV10EPC25922V30DS02Dto;
 import it.gov.pagopa.rtp.activator.model.generated.epc.DocumentEPC25922V30DS02Dto;
+import it.gov.pagopa.rtp.activator.model.generated.epc.ExternalOrganisationIdentification1CodeEPC25922V30DS022WrapperDto;
 import it.gov.pagopa.rtp.activator.model.generated.epc.ExternalOrganisationIdentification1CodeEPC25922V30DS02Dto;
 import it.gov.pagopa.rtp.activator.model.generated.epc.ExternalOrganisationIdentification1CodeEPC25922V30DS02WrapperDto;
 import it.gov.pagopa.rtp.activator.model.generated.epc.ExternalPurpose1CodeWrapperDto;
@@ -64,6 +65,7 @@ public SepaRequestToPayRequestResourceDto toRequestToPay(Rtp rtp) {
                 dbtExternalOrganisationIdentification1CodeEPC25922V30DS02WrapperDto
                                 .setCd(ExternalOrganisationIdentification1CodeEPC25922V30DS02Dto.BOID);// FIXED
 
+
                 GenericOrganisationIdentification1EPC25922V30DS02Dto dbtGenericOrganisationIdentification1EPC25922V30DS02Dto = new GenericOrganisationIdentification1EPC25922V30DS02Dto();
                 dbtGenericOrganisationIdentification1EPC25922V30DS02Dto.setId(rtp.payerId());
                 dbtGenericOrganisationIdentification1EPC25922V30DS02Dto
@@ -205,7 +207,7 @@ public SepaRequestToPayRequestResourceDto toRequestToPay(Rtp rtp) {
                                 .setDbtrAgt(dbtBranchAndFinancialInstitutionIdentification6EPC25922V30DS02Dto);
                 paymentInstruction42EPC25922V30DS02Dto.setCdtTrfTx(lCreditTransferTransaction57EPC25922V30DS02Dtos);
 
-                List<PaymentInstruction42EPC25922V30DS02Dto> listPaymentInstruction42EPC25922V30DS02Dto = new ArrayList<PaymentInstruction42EPC25922V30DS02Dto>();
+                List<PaymentInstruction42EPC25922V30DS02Dto> listPaymentInstruction42EPC25922V30DS02Dto = new ArrayList<>();
                 listPaymentInstruction42EPC25922V30DS02Dto.add(paymentInstruction42EPC25922V30DS02Dto);
 
                 CreditorPaymentActivationRequestV10EPC25922V30DS02Dto creditorPaymentActivationRequestV10EPC25922V30DS02Dto = new CreditorPaymentActivationRequestV10EPC25922V30DS02Dto();

diff --git a/src/test/java/it/gov/pagopa/rtp/activator/controller/SendAPIControllerImplTest.java b/src/test/java/it/gov/pagopa/rtp/activator/controller/SendAPIControllerImplTest.java
@@ -35,7 +35,7 @@
 @WebFluxTest(controllers = { SendAPIControllerImpl.class })
 @Import({ SecurityConfig.class })
 @DisabledInAotMode
-public class SendAPIControllerImplTest {
+class SendAPIControllerImplTest {
 
     @MockBean
     private SendRTPService sendRTPService;

diff --git a/src/test/java/it/gov/pagopa/rtp/activator/domain/payer/PayerIDTest.java b/src/test/java/it/gov/pagopa/rtp/activator/domain/payer/PayerIDTest.java
@@ -1,8 +1,6 @@
 package it.gov.pagopa.rtp.activator.domain.payer;
 import org.junit.jupiter.api.Test;
 
-import it.gov.pagopa.rtp.activator.domain.payer.PayerID;
-
 import static org.junit.jupiter.api.Assertions.*;
 import java.util.UUID;
 

diff --git a/src/test/java/it/gov/pagopa/rtp/activator/domain/rtp/ResourceIDTest.java b/src/test/java/it/gov/pagopa/rtp/activator/domain/rtp/ResourceIDTest.java
@@ -7,7 +7,7 @@
 
 import org.junit.jupiter.api.Test;
 
-public class ResourceIDTest {
+class ResourceIDTest {
       @Test
     void testCreateNew() {
         ResourceID resourceID = ResourceID.createNew();

diff --git a/src/test/java/it/gov/pagopa/rtp/activator/repository/activation/ActivationMapperTest.java b/src/test/java/it/gov/pagopa/rtp/activator/repository/activation/ActivationMapperTest.java
@@ -4,8 +4,6 @@
 
 import it.gov.pagopa.rtp.activator.domain.payer.Payer;
 import it.gov.pagopa.rtp.activator.domain.payer.PayerID;
-import it.gov.pagopa.rtp.activator.repository.activation.ActivationEntity;
-import it.gov.pagopa.rtp.activator.repository.activation.ActivationMapper;
 
 import static org.junit.jupiter.api.Assertions.*;
 

diff --git a/src/test/java/it/gov/pagopa/rtp/activator/service/rtp/SendRTPServiceTest.java b/src/test/java/it/gov/pagopa/rtp/activator/service/rtp/SendRTPServiceTest.java
@@ -24,7 +24,7 @@
 import reactor.test.StepVerifier;
 
 @ExtendWith(MockitoExtension.class)
-public class SendRTPServiceTest {
+class SendRTPServiceTest {
 
     @Mock
     private SepaRequestToPayMapper sepaRequestToPayMapper;

diff --git a/src/test/java/it/gov/pagopa/rtp/activator/service/rtp/SepaRequestToPayMapperTest.java b/src/test/java/it/gov/pagopa/rtp/activator/service/rtp/SepaRequestToPayMapperTest.java
@@ -15,7 +15,7 @@
 import java.time.LocalDate;
 import java.time.LocalDateTime;
 
-public class SepaRequestToPayMapperTest {
+class SepaRequestToPayMapperTest {
 
     @Mock
     private Rtp rtp;