Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix the retag step in pipeline cd #25

Merged
merged 1 commit into from
Nov 29, 2024
Merged

chore: Fix the retag step in pipeline cd #25

merged 1 commit into from
Nov 29, 2024

Conversation

and-mora
Copy link
Contributor

@and-mora and-mora commented Nov 29, 2024 •
edited
Loading

Description

In the re-tag image step the image is not found. Therefore a docker pull has been added as first command.

List of Changes

Motivation and Context

How Has This Been Tested?

  • Pre-Deploy Test
    • Unit
    • Integration (Narrow)
  • Post-Deploy Test
    • Isolated Microservice
    • Broader Integration
    • Acceptance
    • Performance & Load

Types of changes

  • PATCH - Bug fix (backwards compatible bug fixes)
  • MINOR - New feature (add functionality in a backwards compatible manner)
  • MAJOR - Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@and-mora and-mora requested review from a team as code owners November 29, 2024 09:16
@lucaconsalvi lucaconsalvi changed the title chore: fix the retag step in pipeline cd chore: Fix the retag step in pipeline cd Nov 29, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@and-mora and-mora merged commit a6760dc into main Nov 29, 2024
14 of 17 checks passed
@and-mora and-mora deleted the fix-retag-step-pipeline-cd branch November 29, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucaconsalvi lucaconsalvi lucaconsalvi approved these changes

@TommasoLencioni TommasoLencioni TommasoLencioni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@and-mora @TommasoLencioni @lucaconsalvi