Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix re-tagging step in deploy workflow #30

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

and-mora
Copy link
Contributor

@and-mora and-mora commented Dec 4, 2024

Description

The PR proposes to fix the deploy workflow. Right now the command docker image push --all-tags fails because the tag reference is not admitted in the image

List of Changes

Motivation and Context

How Has This Been Tested?

  • Pre-Deploy Test
    • Unit
    • Integration (Narrow)
  • Post-Deploy Test
    • Isolated Microservice
    • Broader Integration
    • Acceptance
    • Performance & Load

Types of changes

  • PATCH - Bug fix (backwards compatible bug fixes)
  • MINOR - New feature (add functionality in a backwards compatible manner)
  • MAJOR - Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@and-mora and-mora requested review from a team as code owners December 4, 2024 15:35
@and-mora and-mora merged commit cee80db into main Dec 4, 2024
2 of 3 checks passed
@and-mora and-mora deleted the fix-retagging-step-in-deploy-workflow branch December 4, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants