Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add draft status to signals #321

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

blang
Copy link

@blang blang commented Jun 15, 2022

Adding the draft status to signals allows to ignore pull requests for
auto-merge if they are in draft status.

Example:

merge:
    ignore:
        draft: true

Adding the draft status to signals allows to ignore pull requests for
auto-merge if they are in draft status.

Example:
```yaml
merge:
    ignore:
        draft:true
```
@palantirtech
Copy link
Member

Thanks for your interest in palantir/bulldozer, @blang! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@bluekeyes
Copy link
Member

Thanks for adding this! As a signal, this implementation looks good, but I don't think a signal/option is necessary. My understanding is that GitHub does not allow merging draft pull requests, so it should be safe for Bulldozer to always ignore draft PRs when processing merges.

@blang
Copy link
Author

blang commented Jun 16, 2022

Currently only tested this with github enterprise 3.3.1 which actually resulted in the PR to be merged despite being in draft state. I was thinking the same but definitely verified this behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants