Excavator: Upgrades Baseline to the latest version #2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carterkozak
reviewed
Sep 29, 2023
| @@ -121,9 +121,9 @@ public void connect(ConnectionEndpoint endpoint, TimeValue connectTimeout, HttpC | |||
| long beginNanos = System.nanoTime(); | |||
| try (CloseableTracer ignored = CloseableTracer.startSpan("Dialogue ConnectionManager.connect")) { | |||
| manager.connect(endpoint, connectTimeout, context); | |||
| connectTimerSuccess.update(System.nanoTime() - beginNanos, TimeUnit.NANOSECONDS); | |||
There was a problem hiding this comment.
👎 this is performance sensitive, we shouldn't allocate Duration objects
carterkozak
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
excavator is a bot for automating changes across repositories.
Changes produced by the roomba/latest-baseline-oss check.
To enable or disable this check, please contact the maintainers of Excavator.