-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π₯ Notifications got better. #325
π₯ Notifications got better. #325
Conversation
Notifications package. π₯ Notifications no longer create a custom separate stage for them to show rather use the parent application's stage.
@infinite-dev22 Almost ready to merge, there's just a little mistake that needs to be fixed, I left a comment |
@palexdev Hope you are well, Sir. I didn't find the comment left on the mistake to be fixed. Thank you. |
demo/src/main/java/io/github/palexdev/materialfx/demo/controllers/NotificationsController.java
Outdated
Show resolved
Hide resolved
Do you see it now? |
Yes, good Sir |
@infinite-dev22 can you make the change by the end of the week, so I continue working/release? |
Yes Sir, I can, Sorry for late response. Just a busy month for me. Let make the change |
Though when I fetch the change seems to already exist |
β¦ications correctly.
@palexdev, this has been resolved |
Though a few questions about the change made, does the height have to be manually set. Can this be set to scale with the notifications. |
Long story short: no, it has to be done manually More details: Maybe a solution could be found with bindings but the container for the notifications is a VirtualFlow, so every notification must have the same height. Not only that, since it uses the old VirtualFlow implementation, the size is not a property of the flow but must be hard coded into the cell class |
I realized, I have tried setting the size automatically and the Notifications seemed to all be the same size as the first Notification displayed. **Edit
|
Yeah, easier said than done unfortunately. Long story short: VirtualizedFX things. are. complicated. |
Notifications package.
π₯ Notifications no longer create a custom separate stage for them to show rather use the parent application's stage.
π₯ No seperate windows created for notification system
β Top left corner nolonger blocked by notification stage window.