Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mongodb backend #214

Merged
merged 22 commits into from
Feb 11, 2024
Merged

Mongodb backend #214

merged 22 commits into from
Feb 11, 2024

Conversation

wangsha
Copy link
Contributor

@wangsha wangsha commented Jan 11, 2023

  • fixes #

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@wangsha
Copy link
Contributor Author

wangsha commented Jan 11, 2023

setting up mac docker is not stable. suggest re-run the failed job multiple times. success run : https://github.com/wangsha/cachelib/actions/runs/3889456857

@northernSage northernSage added new feature Implementation of or related to a new feature ongoing review labels Feb 10, 2024
@northernSage northernSage self-requested a review February 10, 2024 14:03
@northernSage northernSage mentioned this pull request Feb 10, 2024
2 tasks
Copy link
Member

@northernSage northernSage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @wangsha, thanks a lot for the work! I had to solve a few dependency resolution conflicts due to latest pushes to main branch, everything else is looking good 👍🏻

@northernSage northernSage merged commit b76abc3 into pallets-eco:main Feb 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Implementation of or related to a new feature ongoing review
Development

Successfully merging this pull request may close these issues.

2 participants