Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tests to use pytest fixtures and avoid unittest.TestCase #213

Merged
merged 4 commits into from
May 21, 2024
Merged

Refactor tests to use pytest fixtures and avoid unittest.TestCase #213

merged 4 commits into from
May 21, 2024

Conversation

danwuSBU
Copy link
Contributor

@danwuSBU danwuSBU commented May 21, 2024 •
edited
Loading

per discussion with @davidism

  • bring all tests out of TestCases
  • use a pytest.fixture instead of unittest setUp/tearDown
  • use assert and pytest.raises() instead of unittest assertEqual, assertRaises, etc.
  • move tests to separate files

@danwuSBU danwuSBU force-pushed the refactoring_unittest branch from fff5517 to 510724e Compare May 21, 2024 18:33
davidism
davidism reviewed May 21, 2024
View reviewed changes
tests/conftest.py Outdated Show resolved Hide resolved
@danwuSBU danwuSBU requested a review from davidism May 21, 2024 19:24
@davidism davidism merged commit 21cec39 into pallets-eco:main May 21, 2024
7 checks passed
@danwuSBU danwuSBU deleted the refactoring_unittest branch May 21, 2024 19:29
@davidism davidism added this to the 0.10.0 milestone May 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidism davidism Awaiting requested review from davidism

Assignees
No one assigned
Labels
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@danwuSBU @davidism