-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make PANDA startup quieter #1350
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So long as LOG_ERROR shows up by default (or maybe just always? Would be awkward to not print some of those errors) this looks great to me.
Yes. The default log level does show |
@lacraig2 do you think we could silence more of these, either by reducing log level or changing what we log with pypanda? I'm looking to silence this output from pypanda where I load syscalls2 and OSI
|
@AndrewFasano are you looking for a way to silence these generally or in a specific use case? If you're willing to accept the latter we might consider building out an API around the panda/panda/include/panda/debug.h Line 73 in 1d0069e
|
I think I'd like to either These logs aren't really important warnings so I'm not too opposed to option A - I think all 4 of these messages could be logged at the debug level |
I think that 3 of 4 of those messages could be debug level. The one that perhaps shouldn't be is:
I could see a case for the optional fields (like this one) being at the debug level. I do think B makes sense in general. |
This PR changes
callbacks.c
to use theLOG_*
format (LOG_ERROR
,LOG_WARNING
, etc).It also makes PANDA somewhat quieter by default with LOG formats that won't necessarily be seen for most items if PANDA's debug mode isn't set quite low.