Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt 2 on publishing wheel #1467

Merged
merged 5 commits into from
Mar 15, 2024
Merged

Attempt 2 on publishing wheel #1467

merged 5 commits into from
Mar 15, 2024

Conversation

AndrewQuijano
Copy link
Collaborator

I did a bit more investigating on publishing wheel files and found this link:
pypa/gh-action-pypi-publish#15

Based on the information here, I updated the YAML to repeat what they did for releasing py panda
https://github.com/ansible/pylibssh/blob/17e8683/.github/workflows/build-test-n-publish.yml#L353-L357
https://github.com/ansible/pylibssh/releases

@lacraig2
Copy link
Member

lacraig2 commented Feb 26, 2024

I tried getting this workflow working several times and on each of the runs the whl file was missing.

https://github.com/panda-re/panda/actions/runs/8035190848/job/21947562763#step:5:11

This version looks like we've changed to release assets and now uploading the the whole folder as release assets.

@AndrewQuijano
Copy link
Collaborator Author

AndrewQuijano commented Feb 26, 2024

Hm, so technically the file is specifically called 'pandare-0.1.2.0-py3-none-any.whl' after I finish running setup. I do try to be flexible with the naming in case any changes occur to setup.py.

I'm a bit surprised as when I run this locally, I do get the wheel file

@lacraig2
Copy link
Member

I also get the whl file locally.

I'm not quite sure what the issue is.

@AndrewQuijano
Copy link
Collaborator Author

Actually, I just noticed there is a whole pypackage. Could we not use GitHub actions to automate updating the pip package?

https://pypi.org/project/pandare/#description

@AndrewQuijano
Copy link
Collaborator Author

@lacraig2
Copy link
Member

@AndrewQuijano now that the whl is small I think that would be fine.

@AndrewQuijano
Copy link
Collaborator Author

After a quick chat with Brendan, apparently * is not allowed, so I used this comment for a work around. I will also work on pypi upload too on this PR.

actions/upload-release-asset#47 (comment)

@AndrewQuijano
Copy link
Collaborator Author

I made a first attempt at writing the job to publish to pypi, I will likely need help from MITLL to get the secret and all to get this working too.

Also, I should note, currently for python, protobuf 3.20.0 is the latest version that works with the installed version of protobuf. Not sure if you suggest I update the pypanda requirements for this?

https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/

…ments.txt instead of from apt-get for easier version control
…requirements.txt to avoid any drift. I do know this has caused me issues before that requirements.txt and install requirements did not match before
@AndrewQuijano
Copy link
Collaborator Author

For transparency, I am also working on updating how python package dependencies are managed. I will run the test debian package set up later tonight to confirm this works.

We should avoid having 3 separate places where we install a python package.

@lacraig2
Copy link
Member

lacraig2 commented Mar 6, 2024

We should avoid having 3 separate places where we install a python package.

❤️

@AndrewQuijano
Copy link
Collaborator Author

packages_made
pip_worked

@lacraig2
Copy link
Member

I think this isn't passing tests for unrelated reasons.

@AndrewQuijano I will merge this if you think it's ready.

@lacraig2 lacraig2 merged commit 4d0ba99 into panda-re:dev Mar 15, 2024
4 of 5 checks passed
lacraig2 added a commit that referenced this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants