Reduce memory usage when LLVM is enabled. #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function pass manager objects were being created, but never destroyed. When a function pass manager object is destroyed, it destroys all pass objects that have been registered. Previously pass objects were being reused, which is why the pass managers were never being freed, but this results in a large memory leak. This commit shuffles things around so the pass managers can be freed. a891
|
Thanks Mark! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function pass manager objects were being created, but never destroyed.
When a function pass manager object is destroyed, it destroys all pass objects that have been registered. Previously pass objects were being reused, which is why the pass managers were never being freed, but this results in a large memory leak. This commit shuffles things around so the pass managers can be freed.
a891