[WIP] Clean up Dockerfile and update loaded to support 64-bits #1563
+189
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewQuijano
force-pushed
the
remove-extra-installs
branch
4 times, most recently
from
49fb311 to
ade6a46
Compare
AndrewQuijano
force-pushed
the
remove-extra-installs
branch
6 times, most recently
from
2498326 to
ffde8fe
Compare
AndrewQuijano
changed the title
AndrewQuijano
changed the title
AndrewQuijano
force-pushed
the
remove-extra-installs
branch
from
b9e901d to
b88986e
Compare
AndrewQuijano
force-pushed
the
remove-extra-installs
branch
from
b88986e to
a6ba39b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I figure it would be a good idea to remove all duplicate instances of pip install. Note, cffi requires pycparser, so it gets installed for free with cffi.
I will likely save for next PR, but it seems both wheel and apt have the later version of cffi that works, I wonder why it is blowing up when I use
apt-get install python3-cffiAlso, I did a little bit of clean up on Dockerfile to use an argument for INSTALL_PREFIX and an easier way to create LD_LIBRARY_PATH using TARGET_LIST
Also, I want to close #1547 with this PR based on work done by Zhenghao (He wrote dwarf2 plugin used in current LAVA version).
https://github.com/HighW4y2H3ll/panda/blob/x64dev/panda/plugins/loaded/loaded.cpp
loaded.cpp.txt