The Lost Episodes of 2022 #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the User Character, Equipment, and Statistic Data structures, User Caddie Data is similarly reused between multiple packets.
More details for GSC-0006 and response GSS-006B.
Perhaps useless, but this is low hanging fruit. User Statistics Data had to be split, as there is a 78-byte data block of currently-unknown use at the end in GSS-0044 and GSS-0045 that does not appear in GSS-0158.
Another duplicated structure presents itself, this time with course records. The extra course-specific slots of GSS-0045 appear in GSS-015C, too.
Continuing on the path of cleaning up GSC-002F responses, another repeated data structure has been extracted (user_name_data), along with pointing most of the GSC-002F responses to their appropriate shared structure definitions instead of bespoke individual definitions that are liable to be left incomplete when work happens elsewhere. Because of the extensive use of these shared structures, a surprising amount of extra information can be gathered about other accounts that wouldn't be displayed in-game, such as current pang balance or exact equipment loadout. Third party implementations of the server might see fit to blank out this information where it's not absolutely necessary.
A minor observation that the current server's ID appears in the token portion of the challenge and response. Also documented are the range of lengths of responses.
While GSS-0158 is mostly a response to GSC-002F, it's also sent as a response to GSC-0002, but almost entirely blanked out. Very odd.
Various packets regarding ending of holes, matches and tournaments here; GSC-0031 is similar to GSC-0006, but sent after every hole. GSC-00AA is identical to GSC-0006, but sent when using a Tiki Report instead of allowing a tournament to end naturally. The format for all three of these packets have been split off into user_course_record_data. While tournaments ending as a result of GSC-00AA is obvious, a new method was needed for grouping packets that didn't directly result from some other packet. Tentatively calling these 'events', the first such event is that of a match or tournament ending, with GSC-0006 and 10 GSS packets joining that list. Lastly, GSS-012A is noted as a dedicated response to using a Tiki Report with GSC-00AA, separate from it acting as a combination GSC-0006, GSC-000F, and tournament end.
|
PR already made a year ago with updates, still haven't merged them for reasons? |
|
not sure what happened, but it's merged now. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why none of these were pushed a year ago, I don't know.