Migrate to MinGW32, remove slipstream, statically link ijl15 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big one, and hopefully one of the last big PRs like this for Rugburn.
Instead of using Slipstream to integrate Rugburn into ijl15, we link ijl15 directly into our binary. This can be done using MinGW instead of OpenWatcom, removing the need for the bespoke OpenWatcom-based toolchain. This means we no longer need a web patcher, so the webpage can just be fully static, so we can get rid of all of the website-related stuff except for a single static HTML file. We can remove a lot of bootstrapping code and directly link to GetProcAddress and LoadLibraryA, which might let us resurrect Windows 98 support (increasingly important now that we support versions of PangYa that should work on Windows 98.)
The resulting binary is smaller than the original ijl15.dll, since it does not statically link msvcrt. That said, this is still mostly untested.
Still TODO: need to update MSVC build. It should be even more straight-forward than the GCC build.
IANAL, but license-wise, IJL15 is freely redistributable, so we can link it with anything we want that is permissive enough (essentially, just not copyleft.) So with the new permissive length disassembler, this should be clear to redistribute. The ijl15 license text is included already in the repo.