Fix MinGW hang issue #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hunt begins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: For now this just reproduces the issue by having IJL throw an exception.OK: The identified problem is fixed now. It was a problem with the shim for
_aullshr. For MSVC, we had some inline asm that was effectively equivalent to MS's implementation, but for GCC we were just falling back on the fact that MinGW can just generate this code. However, for some reason, my_aullshrstub was set to__stdcall. It's pretty blatantly obvious from the MSVC version that this is not correct.We already need some stuff that has to be expressed in assembly language (at least
__except_list) so I remove the hardcodedrtsyms.ofile and move_aullshrand all of the special symbols tostubs.Sandstubs.asm(for MSVC and GCC respectively.)Going to try to figure out if that resolves the problem fully or if there's anything else resolved.
Also, finally enables testing in CI. :)