Clean up CI #38
Merged
Clean up CI #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Actions pipeline is a little crowded. I don't think there's any particular reason to have multiple workflows, there's a fair bit of duplication. We'll reduce parallelism a bit to coalesce the formatting check, else we hit the Nix cache twice per CI run which is silly. We'll make it so that the clang-format check failing doesn't cancel the entire build at least. Hopefully this means that we'll still get an artifact back if the build succeeds.
Also update actions. The old official release actions are deprecated because GitHub is lazy, so we'll move to their recommended third-party action as I did on pangfiles.