C++ Support #41
Open
C++ Support #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the code in Rugburn is getting pretty complex. For better or worse, I believe we can manage some of that complexity (especially around dynamically allocated memory and data structures) using C++ than we can using C.
It is unclear if we will be able to use STL containers or static initializers, it's probably possible, but will need work on both the MinGW and MSVC side to correctly statically link the C++ standard library as well as perform the correct initialization.
P.S.: The amount of casting this introduces is pretty ugly, but it should pay off, as we should be able to introduce templates later on which can make e.g.
HookProctype-checked.