player-data-struct: move 'game' variable to inside the PlayerData struct #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the
Game
variable from thePlayerMainData
to thePlayerData
struct. This is due that thePlayerData
struct is also present when replying to theUser Info Request
packet in the following packet: https://packets.pangdox.com/packets/gameservice/server/0157.htmlIf we omit the
Game
from the struct and open theMy Info
tab we can observe alignment issues:By moving the variable we can see the correct alignment:
Note: i did not test this with the pangbox server but with my own, though i do not expect any issues with the change 👀