Partially Implement Papel Shop #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchv
reviewed
Jul 3, 2023
JMC47
force-pushed
the
hackyrareshopbranch
branch
from
4d174c3
to
3279710
Compare
jchv
approved these changes
Jul 3, 2023
JMC47
force-pushed
the
hackyrareshopbranch
branch
3 times, most recently
from
2226427
to
f2326d2
Compare
jchv
approved these changes
Jul 3, 2023
Co-authored-by: jchv <john@jchw.io>
Co-authored-by: jchv <john@jchw.io>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial implementation of the Papel Shop.
Also implements bare necessities to open the rare shop page at all, which means faking achievement data (for memorial shop.) Also adds a WeightedRandom generation.
The Papel Shop itself does visually function, though there are some packet differences between US852 and the reference packet that causes some functionality to be odd. Note that both shops will subtract pang, but you don't actually get the items. I put a random rare item in just for fun, but otherwise tried to match known Papel Shop items from dumped packets.
Big Papel wasn't something I used as much, so I'm not nearly as sure on the implementation. It matches what data I have, but there is a bug saying it has no more rolls. This server ignores that bug and lets you roll anyway, so it can be tested and waste your pang. Big Papel shop is weird and will let your pang go negative, which the game seems totally fine with doing, surprisingly enough. Black Papel shop has a client side check and does not allow you to go negative.