Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix player character data struct stats alignment #50

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

hex-agon
Copy link
Contributor

If we try to give the player N power slots with the current struct layout we'll observe that they do not work but instead are allocated to the curve stat.

Base stats:
image

Equipping a power item with power slot = 1, here we'd expect our power to be 28:
image

Yet if we equip a curve item, we can see it is raised to 14 instead of the expected 13:
image

The offsetted 4 bytes after the stats array is actually the character mastery level (0-10), if we set to 10 we can see the extra bonuses on the Character Mastery screen:
image

@jchv
Copy link
Contributor

jchv commented Jul 14, 2023

Thanks!

@jchv jchv merged commit beba8aa into pangbox:master Jul 14, 2023
2 checks passed
@hex-agon hex-agon deleted the fix-character-stats branch July 14, 2023 02:22
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants