Skip to content

Commit

Permalink
CI: fix invalid name for artifact
Browse files Browse the repository at this point in the history
Namely:
```
Error: The artifact name is not valid: archives-linux/amd64-x86_64. Contains the following character:  Forward slash /

Invalid characters include:  Double quote ", Colon :, Less than <, Greater than >, Vertical bar |, Asterisk *, Question mark ?, Carriage return \r, Line feed \n, Backslash \, Forward slash /

These characters are not allowed in the artifact name due to limitations with
certain file systems such as NTFS. To maintain file system agnostic behavior,
these characters are intentionally not allowed to prevent potential problems
with downloads on different file systems.
```
  • Loading branch information
panglesd committed Sep 12, 2024
1 parent 71df46a commit 5698b96
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ jobs:
# if: startsWith(github.ref, 'refs/tags/')
uses: actions/upload-artifact@v4
with:
name: archives-${{ matrix.platform.name }}-${{ matrix.platform.target_arch }}
name: archives-linux-${{ matrix.platform.target_arch }}
path: new_release/*

mac-build:
Expand All @@ -84,7 +84,7 @@ jobs:
matrix:
config:
- { os: "macos-13", arch: "x86_64" }
- { os: "macos-14", arch: "xarm64" }
- { os: "macos-14", arch: "arm64" }
ocaml-compiler:
- 4.14.x
runs-on: ${{ matrix.config.os }}
Expand Down Expand Up @@ -112,7 +112,7 @@ jobs:
mkdir -p new_release;
export OUTPUT=$PWD/new_release;
export TARGETOS=macos;
export TARGETARCH={{ matrix.config.arch }};
export TARGETARCH=${{ matrix.config.arch }};
export VERSION=$GITHUB_REF_NAME;
opam exec -- bash release/release.sh
Expand Down

0 comments on commit 5698b96

Please sign in to comment.