-
-
Notifications
You must be signed in to change notification settings - Fork 639
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
use explicit setup-python versions over implicit expose- (Cherry-pick…
… of #21568, #21582) (#21668) The project is currently using a mix of the GitHub supplied `setup-python` action and `pantsbuild/actions/expose-pythons`. On GitHub managed runners they behave similarly: * `setup-python` will install a version of Python if missing, or add it to the PATH if already present at the expected location (managed runners historically have multiple Pythons baked into the image) * `expose-pythons` will add all Python's at the expected GitHub location to the PATH. (Which ones is up to GitHub.) So today the invocation of `setup-python` followed by `expose-pythons` is redundant. Consolidating on `setup-python` let's us be explicit about expected versions (more like the ARM image) and reduces the number of custom actions the project manages while still making multiple Python versions available. NOTE: The awkward double newlines in the final yaml are a pre-existing issue https://stackoverflow.com/questions/45004464/yaml-dump-adding-unwanted-newlines-in-multiline-strings See #21552 for some history regarding the `setup-` vs `expose-` actions. --------- Co-authored-by: cburroughs <chris.burroughs@gmail.com>
- Loading branch information
1 parent
6fad8c6
commit 3413de5
Showing
5 changed files
with
213 additions
and
90 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.