Replace node-time with moment-timezone #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I dumped the stringified JSON representation of
zoneInfo.utcStandardOffsetSecondsByTimeZoneId into a file with the old
implementation, and again with the new based on moment-timezone.
There is no diff between the two JSON files. Below is the example code
used to generate them:
```js
const ZoneInfo = require("./lib/ZoneInfo");
const ZoneInfoMoment = require("./lib/ZoneInfo-moment");
const zoneInfo = new ZoneInfo("/usr/share/zoneinfo");
const zoneInfoMoment = new ZoneInfoMoment("/usr/share/zoneinfo");
const fs = require('fs')
fs.writeFileSync('zoneInfoTime.json', JSON.stringify(zoneInfo.utcStandardOffsetSecondsByTimeZoneId, null, 2));
fs.writeFileSync('zoneInfoMoment.json', JSON.stringify(zoneInfoMoment.utcStandardOffsetSecondsByTimeZoneId, null, 2));
```
|
Released in 2.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I dumped the stringified JSON representation of
zoneInfo.utcStandardOffsetSecondsByTimeZoneIdinto a file with the oldimplementation, and again with the new based on moment-timezone.
There is no diff between the two JSON files. Below is the example code used to generate them:
There was no specific tests of this module, but the build still works.
I wanted to use https://github.com/prantlf/timezone-support instead of moment-timezone, but due to prantlf/timezone-support#33 and the fact that they do not have a way for us to tell if a date is DST, I had to go with moment.