Merge branch 'develop' into release

paperwm · May 23, 2024 · 6165935 · 6165935
2 parents 0eadc7a + 45d7b6a
commit 6165935
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/metadata.json b/metadata.json
@@ -5,7 +5,7 @@
   "url": "https://github.com/paperwm/PaperWM",
   "settings-schema": "org.gnome.shell.extensions.paperwm",
   "shell-version": [ "45", "46" ],
-  "version-name": "46.10.0",
+  "version-name": "46.10.1",
   "donations": {
     "buymeacoffee": "jaytaala",
     "patreon": "valpackett"

diff --git a/tiling.js b/tiling.js
@@ -3882,27 +3882,28 @@ export function insertWindow(metaWindow, { existing }) {
             ensureViewport(space.selectedWindow, space);
             space.setSpaceTopbarElementsVisible(true);
 
+            let slurpPosition;
             switch (Settings.prefs.open_window_position) {
             case Settings.OpenWindowPositions.DOWN:
-                stackSlurpTimeout = GLib.timeout_add(
-                    GLib.PRIORITY_DEFAULT,
-                    100,
-                    () => {
-                        slurp(active, SlurpInsertPosition.BELOW);
-                        return false; // on return false destroys timeout
-                    });
+                slurpPosition = SlurpInsertPosition.BELOW;
                 break;
             case Settings.OpenWindowPositions.UP:
+                slurpPosition = SlurpInsertPosition.ABOVE;
+                break;
+            }
+
+            // if need to slurp (i.e. vertical stack)
+            if (slurpPosition) {
                 stackSlurpTimeout = GLib.timeout_add(
                     GLib.PRIORITY_DEFAULT,
                     100,
                     () => {
-                        slurp(active, SlurpInsertPosition.ABOVE);
+                        slurp(active, slurpPosition);
                         return false; // on return false destroys timeout
                     });
-                break;
             }
         });
+
         return;
     }