Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(primitives): add AddressLocation type and methods #4182

Closed
wants to merge 1 commit into from
Closed

feat(primitives): add AddressLocation type and methods #4182

wants to merge 1 commit into from

Conversation

perama-v
Copy link

Description

Progress toward

Changes made

  • Introduces AddressLocation which is a wrapper on TxNumber. For an appearance that occurs in a block field (like "miner", it represents this as a TxNumber with bitflags.
  • Adds round trip conversion test cases for AddressLocation.

TODO

  • Design table, likely:
    • Use IntegerList, containing AddressLocation as elements
    • Maps address -> AddressLocationList
    • Potentially use a Shardedkeyas one address may have manyAddressLocation`

@perama-v perama-v requested a review from gakonst as a code owner August 14, 2023 05:34
@perama-v perama-v marked this pull request as draft August 14, 2023 05:34
@perama-v perama-v mentioned this pull request Aug 14, 2023
Open
@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Oct 15, 2023
@rkrasiuk rkrasiuk added M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity and removed S-stale This issue/PR is stale and will close with no further activity labels Oct 19, 2023
@gakonst
Copy link
Member

gakonst commented Jan 9, 2024

Closing this as stale, we'll re-incorporate these ideas as we venture into custom stages with Reth CLI Extensions and the Declarative Node Builder API that @mattsse is spearheading.

@gakonst gakonst closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst Awaiting requested review from gakonst

@Rjected Rjected Awaiting requested review from Rjected Rjected will be requested when the pull request is marked ready for review Rjected is a code owner

Assignees
No one assigned
Labels
M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@perama-v @gakonst @rkrasiuk